danny0405 commented on a change in pull request #2113:
URL: https://github.com/apache/calcite/pull/2113#discussion_r475031661



##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -10435,32 +10435,30 @@ private void checkCustomColumnResolving(String table) 
{
         + "size => interval '1' hour))")
         .fails("Param 'data' not found in function 'SESSION'; did you mean 
'DATA'\\?");
     sql("select * from table(\n"
-        + "^session(\n"
+        + "session(\n"
         + "data => table orders,\n"
         + "key => descriptor(productid),\n"

Review comment:
       That is because 
`SqlSessionTableFunction.OperandMetadataImpl.checkOperandTypes` allows that for 
the descriptor. You should check the operands based on the operand name, using 
the new introduced `SqlOperandMetadata`. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to