vlsi commented on a change in pull request #2124:
URL: https://github.com/apache/calcite/pull/2124#discussion_r479556442
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -653,15 +657,19 @@ private RexNode simplifyUnaryPlus(RexCall call,
RexUnknownAs unknownAs) {
return simplify(call.getOperands().get(0), unknownAs);
}
- private RexNode simplifyIs(RexCall call, RexUnknownAs unknownAs) {
+ private @Nonnull RexNode simplifyIs(RexCall call, RexUnknownAs unknownAs) {
Review comment:
Should we use `nonnull` for arguments and return values by default? In
that case, there's no point in adding `@Nonnull` annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
