[GitHub] [calcite] vlsi commented on a change in pull request #2124: [CALCITE-4173] Add internal SEARCH operator and Sarg literal that represents a set of values or ranges

[GitBox]

vlsi commented on a change in pull request #2124:
URL: https://github.com/apache/calcite/pull/2124#discussion_r479557881



##########
File path: 
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
##########
@@ -6976,7 +6976,7 @@ GROUP by deptno, job]]>
         </Resource>
         <Resource name="plan">
             <![CDATA[
-LogicalProject(JOB_NAME=[CASE(OR(=($1, '810000'), =($1, '820000')), $1, 
'error':VARCHAR(10))], EXPR$1=[$2])
+LogicalProject(JOB_NAME=[CASE(SEARCH($1, Sarg[_ISO-8859-1'810000', 
_ISO-8859-1'820000']:CHAR(6)), $1, 'error':VARCHAR(10))], EXPR$1=[$2])

Review comment:
       Could we trim the default encoding when dumping string literals within 
`Sarg`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org