rubenada commented on a change in pull request #2128:
URL: https://github.com/apache/calcite/pull/2128#discussion_r481869541
##########
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##########
@@ -883,7 +917,8 @@ private RelOptSchema getSchema(RelNode rel) {
* Deserialize a relnode from the json string by {@link RelJsonReader},
* and dump it to text format.
*/
- private String deserializeAndDumpToTextFormat(RelOptSchema schema, String
relJson) {
+ private String deserializeAndDumpToTextFormat(
Review comment:
or maybe just `deserializeAndDump`. BTW the javadoc needs to be updated
as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
