liyafan82 commented on a change in pull request #2128:
URL: https://github.com/apache/calcite/pull/2128#discussion_r481982296
##########
File path: core/src/test/java/org/apache/calcite/plan/RelWriterTest.java
##########
@@ -839,12 +863,22 @@
.build();
final String relJson = RelOptUtil.dumpPlan("", rel,
SqlExplainFormat.JSON, SqlExplainLevel.EXPPLAN_ATTRIBUTES);
- final String result = deserializeAndDumpToTextFormat(getSchema(rel),
relJson);
- final String expected = ""
+ final String result = deserializeAndDumpToTextFormat(getSchema(rel),
relJson, format);
+ assertThat(result, isLinux(expected));
+ }
+
+ @Test void testUDAF() {
+ testUDAF0(SqlExplainFormat.TEXT, ""
Review comment:
Sounds reasonable.
I was having similar thoughts, but gave up because
1. some test cases in the class are not suitable for parameterized testing.
2. since the strings of the expected results take up much space of the
class, parameterizing the class does not significantly reduce the code size.
Do you have any suggestions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
