vlsi commented on pull request #1929: URL: https://github.com/apache/calcite/pull/1929#issuecomment-685681553
@uschindler , thank you so much for the explanation. No need to sorry, and I need to say many thanks for the maintenance of forbidden-apis. As you see, I am still in progress of annotating the code to verify nullness (there are 3000 errors to be fixed), and then I would have the full set of ill classes, and I could either refactor them or do something. I do not think it is worth excluding ResultSetEnumerable from the verification. The reason for other classes are excluded is they have known forbidden calls which can't be avoided (e.g. the code is generated). By the way, if we could use "suppresswarnings" to suppress a single violation, we would go with that rather than excluding the full file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
