vlsi commented on a change in pull request #2135:
URL: https://github.com/apache/calcite/pull/2135#discussion_r483075878
##########
File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java
##########
@@ -217,6 +217,12 @@ public int getScale() {
return SCALE_NOT_SPECIFIED;
}
+ /**
+ * Gets the {@link SqlTypeName} of this type.
+ * Sub-classes must override the method to ensure the resulting value is
non-nullable.
+ *
+ * @return SqlTypeName, never null
+ */
public SqlTypeName getSqlTypeName() {
return null;
Review comment:
The code was like that for ages, and this `return null` is never used in
Calcite (it is always overridden).
Another option could be removing this implementation (the class is
`abstract` anyway), however, that sounds like a backward-incompatible change,
so I just kept the method as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
