danny0405 commented on a change in pull request #2135:
URL: https://github.com/apache/calcite/pull/2135#discussion_r483347297
##########
File path: core/src/main/java/org/apache/calcite/rel/type/RelDataTypeImpl.java
##########
@@ -217,6 +217,12 @@ public int getScale() {
return SCALE_NOT_SPECIFIED;
}
+ /**
+ * Gets the {@link SqlTypeName} of this type.
+ * Sub-classes must override the method to ensure the resulting value is
non-nullable.
+ *
+ * @return SqlTypeName, never null
+ */
public SqlTypeName getSqlTypeName() {
return null;
Review comment:
The code looks weird, the document says it never returns null but there
is a default code returns null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
