rubenada commented on a change in pull request #2143:
URL: https://github.com/apache/calcite/pull/2143#discussion_r485457551
##########
File path: core/src/main/java/org/apache/calcite/rel/RelNode.java
##########
@@ -246,6 +246,8 @@ default String getDigest() {
return getRelDigest().toString();
}
+ String getTreeDigest();
Review comment:
@zabetak +1
I also think it makes sense to deprecate/remove
`RelOptUtil#toString(RelNode)` since there is also a similar (more "powerful")
method that covers that functionality: `RelOptUtil#dumpPlan`.
We could even consider to use it in the default implementation of the new
method for the sake of code re-usability:
````
default String explain() {
return RelOptUtil.dumpPlan("", this, SqlExplainFormat.TEXT,
SqlExplainLevel.EXPPLAN_ATTRIBUTES);
}
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
