[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

[GitBox]

Aaaaaaron commented on a change in pull request #2143:
URL: https://github.com/apache/calcite/pull/2143#discussion_r486105141



##########
File path: core/src/main/java/org/apache/calcite/rel/RelNode.java
##########
@@ -246,6 +246,8 @@ default String getDigest() {
     return getRelDigest().toString();
   }
 
+  String getTreeDigest();

Review comment:
       Hi fellows
   I've updated my code, would you please take a look?
   
   Hi @zabetak Julian commented in the JIRA: "The implementation should 
continue to live in RelOptUtil or wherever", so I just call RelOptUtil.toString 
directly.
   
   Hi @rubenada "RelOptUtil.dumpPlan("", this, SqlExplainFormat.TEXT, 
SqlExplainLevel.EXPPLAN_ATTRIBUTES)"'s output seems the same with 
RelOptUtil.toString.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org