liyafan82 commented on a change in pull request #2243:
URL: https://github.com/apache/calcite/pull/2243#discussion_r517081499
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java
##########
@@ -170,27 +170,27 @@ private void clearProcessed(RelSet set) {
}
}
- // a callback invoked when a RelNode is going to be added into a RelSubset,
- // either by Register or Reregister. The task driver should need to schedule
- // tasks for the new nodes.
+ // A callback invoked when a RelNode is going to be added into a RelSubset,
+ // either by Register or Reregister. The task driver should schedule tasks
+ // for the new nodes.
@Override public void onProduce(RelNode node, RelSubset subset) {
- // if the RelNode is added to another RelSubset, just ignore it.
- // It should be schedule in the later OptimizeGroup task
+ // If the RelNode is added to another RelSubset, just ignore it.
+ // It should be scheduled in the later OptimizeGroup task.
if (applying == null || subset.set
!= VolcanoPlanner.equivRoot(applying.group().set)) {
return;
}
- // extra callback from each task
+ // Extra callback from each task.
if (!applying.onProduce(node)) {
return;
}
if (!planner.isLogical(node)) {
// For a physical node, schedule tasks to optimize its inputs.
// The upper bound depends on all optimizing RelSubsets that this Rel
belongs to.
Review comment:
Rel -> RelNode?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
