liyafan82 commented on a change in pull request #2243:
URL: https://github.com/apache/calcite/pull/2243#discussion_r517082361
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/TopDownRuleDriver.java
##########
@@ -311,31 +311,31 @@ default boolean onProduce(RelNode node) {
}
if (group.taskState != null && upperBound.isLe(group.upperBound)) {
- // either this group failed to optimize before or it is a ring
+ // Either this group failed to optimize before or it is a ring.
return;
}
group.startOptimize(upperBound);
- // cannot decide an actual lower bound before MExpr are fully explored
- // so delay the lower bound checking
+ // Cannot decide an actual lower bound before MExpr are fully explored.
+ // So delay the lower bound check.
- // a gate keeper to update context
+ // A gate keeper to update context.
tasks.push(new GroupOptimized(group));
- // optimize mExprs in group
+ // Optimize mExprs in group.
List<RelNode> physicals = new ArrayList<>();
for (RelNode rel : group.set.rels) {
if (planner.isLogical(rel)) {
tasks.push(new OptimizeMExpr(rel, group, false));
} else if (rel.isEnforcer()) {
- // Enforcers have lower priority than other physical nodes
+ // Enforcers have lower priority than other physical nodes.
physicals.add(0, rel);
} else {
physicals.add(rel);
}
}
- // always apply O_INPUTS first so as to get an valid upper bound
+ // Always apply O_INPUTS first so as to get an valid upper bound.
Review comment:
an -> a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
