julianhyde commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r520041144
##########
File path: core/src/main/java/org/apache/calcite/util/Sarg.java
##########
@@ -170,6 +170,14 @@ public boolean isComplementedPoints() {
.allMatch(RangeSets::isPoint);
}
+ /**
+ * Returns whether this Sarg can be expanded to more simple form, e.g.
+ * the IN call or single comparison.
+ */
+ public boolean isSimple() {
Review comment:
There is no objective definition of 'simple'. I would claim that 'x <>
5' is simple, and so is 'x IS NOT NULL'. You might disagree.
So, this method doesn't belong on `Sarg`. It belongs in whichever piece of
code needs a particular definition of 'simple'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
