julianhyde commented on a change in pull request #2238:
URL: https://github.com/apache/calcite/pull/2238#discussion_r520043528
##########
File path: core/src/test/java/org/apache/calcite/rex/RexProgramTest.java
##########
@@ -1687,10 +1687,8 @@ private void checkExponentialCnf(int n) {
isNotNull(bRef));
// [CALCITE-4352] causes "and b is not null" to disappear from the expanded
// form.
- final String simplified = "AND(SEARCH($0, Sarg[(0..10)]),"
- + " SEARCH($1, Sarg[NOT NULL]))";
- final String expanded =
- "AND(AND(>($0, 0), <($0, 10)), IS NOT NULL($1))";
+ final String simplified = "AND(SEARCH($0, Sarg[(0..10)]), IS NOT
NULL($1))";
+ final String expanded = "AND(AND(>($0, 0), <($0, 10)), IS NOT NULL($1))";
checkSimplify(expr, simplified)
Review comment:
Do you think we should flatten those ANDs in `AND(AND(>($0, 0), <($0,
10)), IS NOT NULL($1))`? I know it might be difficult to achieve efficiently.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
