Aaaaaaron commented on a change in pull request #2253:
URL: https://github.com/apache/calcite/pull/2253#discussion_r520245214
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List<RexNode>
terms,
return e;
}
}
+
+ public RexNode simplifyBoolean(RexNode call) {
Review comment:
@vlsi RexUtil#composeConjunction just converts a collection of
expressions into an AND, and do some true/false optimize.
```
/**
* Converts a collection of expressions into an AND.
* If there are zero expressions, returns TRUE.
* If there is one expression, returns just that expression.
* If any of the expressions are FALSE, returns FALSE.
* Removes expressions that always evaluate to TRUE.
* Returns null only if {@code nullOnEmpty} and expression is TRUE.
*/
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
