Aaaaaaron commented on a change in pull request #2253:
URL: https://github.com/apache/calcite/pull/2253#discussion_r520383312



##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -1688,6 +1690,108 @@ RexNode simplifyAnd2ForUnknownAsFalse(List<RexNode> 
terms,
       return e;
     }
   }
+  
+  public RexNode simplifyBoolean(RexNode call) {

Review comment:
       This set only de-dup case like: "a AND a".
   In my case, the common part is in "OR", the method doesn't split "OR" then 
it will not "addAnd":  "(a=b || c=7) && (a=b || c=7 || d=8)".
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to