xy2953396112 commented on a change in pull request #2094:
URL: https://github.com/apache/calcite/pull/2094#discussion_r524892936
##########
File path: core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
##########
@@ -197,6 +198,10 @@ public boolean isRuleExcluded(RelOptRule rule) {
return this;
}
+ @Override public void addExtraMaterializationRules(List<UnifyRule> rules) {
Review comment:
@jcamachor @zabetak
Thank you very much. I have update the code. The rule of materialized view
is `AbstractUnifyRule`, not `RelOptRule`. I suggest registering materialized
view recognition algorithm through `addMaterializationRules(List<UnifyRule>
rules)`. This interface can also be compatible with `UnifyRule`. If a single
'unifyrule' is registered, it is ok. In the project, we call `
org.apache.calcite . plan.RelOptMaterializations#useMaterializedViews () '
interface for view recognition. Hope to get feedback, thank you again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
