xy2953396112 commented on a change in pull request #2094:
URL: https://github.com/apache/calcite/pull/2094#discussion_r713852598
##########
File path:
core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java
##########
@@ -214,7 +232,11 @@
hepPlanner.setRoot(root);
root = hepPlanner.findBestExp();
- return new SubstitutionVisitor(target, root).go(materialization.tableRel);
+ return new SubstitutionVisitor(target, root, ImmutableList.
+ <SubstitutionVisitor.UnifyRule>builder()
+ .addAll(materializationRules)
+ .addAll(SubstitutionVisitor.DEFAULT_RULES)
Review comment:
Your example is specialized and does not apply to `Calcite`.
In `Calcite`, it should be extended on the default rules.
If you have special needs, external rules can also be registered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
