zabetak commented on a change in pull request #2230:
URL: https://github.com/apache/calcite/pull/2230#discussion_r525197205
##########
File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
##########
@@ -2956,7 +2963,12 @@ public static Object structAccess(Object structObject,
int index, String fieldNa
} else {
Class<?> beanClass = structObject.getClass();
try {
- Field structField = beanClass.getDeclaredField(fieldName);
+ Field structField;
+ if (fieldName == null) {
+ structField = beanClass.getDeclaredFields()[index];
Review comment:
At first glance, option a) does not seem very easy to implement.
Regarding option b) do you expect an exception at runtime when we reach this
part of the code and the feature is disabled or something at a higher layer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
