vlsi commented on a change in pull request #2230:
URL: https://github.com/apache/calcite/pull/2230#discussion_r525226458
##########
File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
##########
@@ -2956,7 +2963,12 @@ public static Object structAccess(Object structObject,
int index, String fieldNa
} else {
Class<?> beanClass = structObject.getClass();
try {
- Field structField = beanClass.getDeclaredField(fieldName);
+ Field structField;
+ if (fieldName == null) {
+ structField = beanClass.getDeclaredFields()[index];
Review comment:
> b)
For instance, we could keep the old behavior.
I guess the previous behavior was "throw NPE since fieldName is null" which
is not user-friendly.
So the fix might be to throw `IllegalArgumentException("fieldName is
unknown, fieldIndex is ..., you might add
calcite.experimental.allow.field.index.access=true to allow index-based field
access")` or something like that.
I think a feature-flag here does not incur high maintenance cost, however, I
think we should refrain from making undefined behavior-like features activated
by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
