jamesstarr commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-730704266
@julianhyde, I renamed SqlLibraryOperators.SUBSTR to SqlLibraryOperators.ORACLE_SUBSTR and I have updated the comment. If I understand you other comments, you are saying the implementation would be straight forward to add a function SqlFunctions and then bind it in BuiltInMethod, so it works for the unit tests. And the benefit of doing this would be that it is more concise and if you translated it back sql, the native function would still used. The disadvantages are that non-oracle targets would have to implement the function themselves and simplification/optimization could not occur since it is not part of the calcites canonical form. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
