julianhyde commented on pull request #2271: URL: https://github.com/apache/calcite/pull/2271#issuecomment-738985305
@jamesstarr The purpose of this bug (as I see it, and as evidenced by the test cases in this PR) is to make sure that the Oracle `SUBSTR` function returns the correct results when run in Calcite's native mode. I acknowledge that I ignored most of your most recent commit. I don't think that it improved things. Your change was based based on the idea that Calcite's standard `SUBSTRING` operator would have different semantics depending on the SQL engine that it is implemented on. That is a deeply flawed assumption. Let's log a follow-up bug (or bugs) to make sure that `SUBSTRING`, and Oracle `SUBSTR`, function correctly when we generate SQL against other engines, and make sure that the fixes include test cases. I have already logged https://issues.apache.org/jira/browse/CALCITE-4427 to restore standards-compliant behavior to the SUBSTRING operator and I am working on it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
