liyafan82 commented on a change in pull request #2273:
URL: https://github.com/apache/calcite/pull/2273#discussion_r528505146
##########
File path: core/src/main/java/org/apache/calcite/adapter/clone/ArrayTable.java
##########
@@ -243,9 +242,9 @@ public static List asList(final Representation
representation,
/** Converts a value set into a compact representation. If
* {@code sources} is not null, permutes. */
- Object freeze(ColumnLoader.ValueSet valueSet, int[] sources);
+ Object freeze(ColumnLoader.ValueSet valueSet, int @Nullable [] sources);
Review comment:
It seems some annotations appear before the type, while others appear
after the type. We should make this consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
