vlsi commented on a change in pull request #2273:
URL: https://github.com/apache/calcite/pull/2273#discussion_r528532716
##########
File path: core/src/main/java/org/apache/calcite/adapter/clone/ArrayTable.java
##########
@@ -446,25 +451,30 @@ public static List asList(final Representation
representation,
return Pair.of(codes, codeValues);
}
+ private static Pair<Object, @Nullable Comparable[]> unfreeze(Object value)
{
Review comment:
The point of the PR is nullability annotations, not code refactoring. In
my opinion, `Pair` should be replaced with properly named classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
