Aaaaaaron commented on pull request #2291:
URL: https://github.com/apache/calcite/pull/2291#issuecomment-738673472
> Hi,
> wouldn't it be easier to read and more general to implement this
short-circuit in RelTraitSet#satisfies, as it is explained in the JavaDoc that
"each trait set satisfies itself"?
> With this change:
>
> ```
> public boolean satisfies(RelTraitSet that) {
> if (this == that){
> return true;
> }
>
> // now the normal check...
> }
> ```
Yes, it's better, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
