julianhyde commented on a change in pull request #2305:
URL: https://github.com/apache/calcite/pull/2305#discussion_r550286858
##########
File path: core/src/test/java/org/apache/calcite/test/TableInRootSchemaTest.java
##########
@@ -97,7 +102,8 @@
private Class[] columnTypes = { String.class, Integer.class };
private Object[][] rows = new Object[3][];
- SimpleTable() {
+ // CHECKSTYLE: IGNORE 1
Review comment:
I wonder what changed; we were using this in tests before.
I see you made `TableInRootSchemaTest` public. Maybe so that you could
reference it from another test? I know that SimpleTable is referenced from a
few tests already, but it's getting to be too much coupling. Better to move the
sub-class into `Smalls`, or something.
I also see that you are calling `Expressions.new_(Constructor)`. Maybe if
you instead called `Expressions.new_(Type)` you would not need a public default
constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
