vvysotskyi commented on a change in pull request #2305:
URL: https://github.com/apache/calcite/pull/2305#discussion_r550334369
##########
File path: core/src/test/java/org/apache/calcite/test/TableInRootSchemaTest.java
##########
@@ -97,7 +102,8 @@
private Class[] columnTypes = { String.class, Integer.class };
private Object[][] rows = new Object[3][];
- SimpleTable() {
+ // CHECKSTYLE: IGNORE 1
Review comment:
In the new test, a `SimpleTable` table is returned by the table
function, so it may actually not be present in the current schema. To simulate
it, I've overridden `SimpleTable.getExpression()` to use table constructor
directly, since the default implementation obtains it by name from the schema.
So it was the change that required changing the modifier.
I've moved `SimpleTable` to the `Smalls` class, also I've removed the
suppression since now it is referenced from different packages, and the public
modifier is legal.
Thanks for referring to the method that accepts type, I've used it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
