rubenada commented on a change in pull request #2356:
URL: https://github.com/apache/calcite/pull/2356#discussion_r583594887
##########
File path: core/src/main/java/org/apache/calcite/rel/type/RelDataType.java
##########
@@ -40,6 +40,11 @@
int SCALE_NOT_SPECIFIED = Integer.MIN_VALUE;
int PRECISION_NOT_SPECIFIED = -1;
+ /**
+ * Suffix for the digests of non-nullable types.
+ */
+ String NON_NULLABLE_TYPE_DIGEST_SUFFIX = " NOT NULL";
Review comment:
I understand @vlsi 's concern. I guess it would be better to define this
constant e.g. in RelDataTypeImpl rather than RelDataType.
@danny0405 I think it is cleaner to "centralize" this constant in one single
place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
