vlsi commented on a change in pull request #2353:
URL: https://github.com/apache/calcite/pull/2353#discussion_r583607305
##########
File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
##########
@@ -2792,27 +2792,28 @@ public static Collection multisetUnionAll(Collection
collection1,
* Function that, given a certain List containing single-item structs (i.e.
arrays / lists with
* a single item), builds an Enumerable that returns those single items
inside the structs.
*/
- public static Function1<Object, Enumerable<Comparable>> flatList() {
+ public static Function1<Object, Enumerable<Object>> flatList() {
Review comment:
Are `null` values acceptable for the resulting function?
In other words, is `inputObject == null` valid or not?
If it is valid, then the signature should better be
```java
What do you think of the following signature?
```suggestion
public static <T> Function1<T, Enumerable<T>> flatList() {
```
If null is not valid, then cast from `inputObject` to `List` should indeed
be like `(List<Object>) ...` which effectively means `the list of non-nullable
Object`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
