rubenada commented on a change in pull request #2353:
URL: https://github.com/apache/calcite/pull/2353#discussion_r583647298



##########
File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java
##########
@@ -2792,27 +2792,28 @@ public static Collection multisetUnionAll(Collection 
collection1,
    * Function that, given a certain List containing single-item structs (i.e. 
arrays / lists with
    * a single item), builds an Enumerable that returns those single items 
inside the structs.
    */
-  public static Function1<Object, Enumerable<Comparable>> flatList() {
+  public static Function1<Object, Enumerable<Object>> flatList() {

Review comment:
       Actually, I think we can do even better / simpler:
   ```
     public static Function1<List<Object>, Enumerable<Object>> flatList() {
       return inputList -> {
         final Enumerator<Object> enumerator = Linq4j.enumerator(inputList);
         ...
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to