rubenada commented on a change in pull request #2363:
URL: https://github.com/apache/calcite/pull/2363#discussion_r591260387
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java
##########
@@ -124,11 +125,19 @@ public abstract Sort copy(RelTraitSet traitSet, RelNode
newInput,
@Override public @Nullable RelOptCost computeSelfCost(RelOptPlanner planner,
RelMetadataQuery mq) {
+ double rowCount = mq.getRowCount(this);
+ if (collation.getFieldCollations().isEmpty()) {
+ return planner.getCostFactory().makeCost(rowCount, 0, 0);
+ }
+ final int offsetValue = offset == null ? 0 : RexLiteral.intValue(offset);
Review comment:
Theoretically, `offset` could not be a `RexLiteral` (e.g. it could be a
`RexCall` or a `RexDynamicParam`), which would lead to an `AssertionError` when
calling `RexLiteral.intValue`. To be on the safe side, this should be checked
before calling this function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
