hqx871 commented on a change in pull request #2363:
URL: https://github.com/apache/calcite/pull/2363#discussion_r591293403
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java
##########
@@ -124,11 +125,19 @@ public abstract Sort copy(RelTraitSet traitSet, RelNode
newInput,
@Override public @Nullable RelOptCost computeSelfCost(RelOptPlanner planner,
RelMetadataQuery mq) {
+ double rowCount = mq.getRowCount(this);
+ if (collation.getFieldCollations().isEmpty()) {
+ return planner.getCostFactory().makeCost(rowCount, 0, 0);
+ }
+ final int offsetValue = offset == null ? 0 : RexLiteral.intValue(offset);
Review comment:
Thanks, I set offset to be 0 if the it is instance of RexDynamicParam as
follow. Am I right ?
offsetValue = offset == null || offset instanceof RexDynamicParam ? 0 :
RexLiteral.intValue(offset);
When offset is a RexCall, the RexLiteral.intValue will compute the final
value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
