devozerov commented on a change in pull request #2369:
URL: https://github.com/apache/calcite/pull/2369#discussion_r593006225
##########
File path: server/src/test/java/org/apache/calcite/test/ServerTest.java
##########
@@ -127,6 +127,16 @@ static Connection connect() throws SQLException {
assertThat(r.getInt(1), is(1));
assertThat(r.next(), is(false));
}
+
+ b = s.execute("create schema if not exists s");
+ assertThat(b, is(false));
Review comment:
@vlsi I do not see any value in it, since these asserts check not for
the outcome of the DDL operation per se, but whether JDBC command returned a
`ResultSet` or not. Obviously, for all DDL statements, it would be `false`. The
incorrect behavior is checked through an exception that would be thrown
otherwise. E.g., if `CREATE OR REPLACE` schema does not re-create the schema,
it would not be possible to create a table with the same name as the table that
existed in the previous schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
