devozerov commented on a change in pull request #2369:
URL: https://github.com/apache/calcite/pull/2369#discussion_r593045926
##########
File path: server/src/test/java/org/apache/calcite/test/ServerTest.java
##########
@@ -127,6 +127,16 @@ static Connection connect() throws SQLException {
assertThat(r.getInt(1), is(1));
assertThat(r.next(), is(false));
}
+
+ b = s.execute("create schema if not exists s");
+ assertThat(b, is(false));
Review comment:
I agree with these comments, but the goal of the ticket was to fix
particular bugs, not refactor the test. The introduced changes do not make the
test more confusing, since they follow the established approach which is used
dozens of times in the same test class. We may refactor the test if needed in a
separate issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
