vlsi commented on a change in pull request #2373:
URL: https://github.com/apache/calcite/pull/2373#discussion_r600340847
##########
File path:
core/src/test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java
##########
@@ -880,6 +880,40 @@ public Service create(AvaticaConnection connection) {
assertThat(updateCount, is(1));
}
+ @Test public void testInsertBatchWithPreparedStatement() throws Exception {
+ final Connection connection = DriverManager.getConnection(
+ "jdbc:avatica:remote:factory="
+ + LocalServiceModifiableFactory.class.getName());
+ assertThat(connection.getMetaData().supportsBatchUpdates(), is(true));
+ assertThat(connection.isClosed(), is(false));
Review comment:
`connection.isClosed()` behavior is not altered in CALCITE-3338, so I do
not see why do you test it here.
Please avoid test duplication. If you want to test `connection.isClosed()`,
then create a dedicated test for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
