xy2953396112 commented on a change in pull request #2373:
URL: https://github.com/apache/calcite/pull/2373#discussion_r710723803
##########
File path:
core/src/test/java/org/apache/calcite/jdbc/CalciteRemoteDriverTest.java
##########
@@ -880,6 +880,34 @@ public Service create(AvaticaConnection connection) {
assertThat(updateCount, is(1));
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-3338";>[CALCITE-3338]
+ * Support preparedStatement executeBatch</a>. */
+ @Test public void testInsertBatchWithPreparedStatement() throws Exception {
+ final Connection connection = DriverManager.getConnection(
+ "jdbc:avatica:remote:factory="
+ + LocalServiceModifiableFactory.class.getName());
+
+ PreparedStatement pst = connection.prepareStatement(
+ "insert into \"foo\".\"bar\" values (?, ?, ?, ?, ?)");
+ pst.setInt(1, 1);
+ pst.setInt(2, 1);
+ pst.setString(3, "second");
+ pst.setInt(4, 1);
+ pst.setInt(5, 1);
+ pst.addBatch();
+ pst.addBatch();
+
+ int[] updateCounts = pst.executeBatch();
+ assertThat(updateCounts.length, is(2));
+ assertThat(updateCounts[0], is(1));
+ assertThat(updateCounts[1], is(1));
Review comment:
check the result of `pst.executeBatch()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
