jibiyr commented on a change in pull request #2382:
URL: https://github.com/apache/calcite/pull/2382#discussion_r602884668



##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
##########
@@ -4223,10 +4234,12 @@ public void visit(RelNode node, int ordinal, @Nullable 
RelNode parent) {
     private final boolean trim;
     private final UnaryOperator<SqlToRelConverter.Config> config;
     private final SqlConformance conformance;
+    private final boolean query;
+

Review comment:
       and we can use like **expr().ok** to test expression later. so I think 
maybe we need the flag. and thanks for your reply  danny




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to