danny0405 commented on a change in pull request #2382:
URL: https://github.com/apache/calcite/pull/2382#discussion_r604543714
##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelTestBase.java
##########
@@ -214,11 +222,13 @@ void assertConvertsTo(
* @param sql SQL query
* @param plan Expected plan
* @param trim Whether to trim columns that are not needed
+ * @param query True if {@code sql} is a query, false if it is an
expression
*/
void assertConvertsTo(
String sql,
String plan,
- boolean trim);
+ boolean trim,
+ boolean query);
Review comment:
Add a new method seems more reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
