jibiyr commented on a change in pull request #2382:
URL: https://github.com/apache/calcite/pull/2382#discussion_r613178973
##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelTestBase.java
##########
@@ -770,7 +795,32 @@ public void assertConvertsTo(
assertConvertsTo(sql, plan, false);
}
+ public void assertConvertsTo(String sql,
+ String plan,
+ boolean trim) {
+ assertConvertsTo(sql, plan, false, true);
+ }
+
public void assertConvertsTo(
+ String sql,
+ String plan,
+ boolean trim,
+ boolean query) {
+ if (query) {
+ assertSqlConvertsTo(sql, plan, trim);
+ } else {
+ assertExprConvertsTo(sql);
+ }
+ }
+
+ private void assertExprConvertsTo(
+ String expr) {
Review comment:
Thanks @danny0405 , I had fixed my idea codeStyle. and I added a test
case which is named testInWithConstantList in SqlToRelConverterTest . It can
cover the code which I made change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
