danny0405 commented on a change in pull request #2382:
URL: https://github.com/apache/calcite/pull/2382#discussion_r606178577
##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelTestBase.java
##########
@@ -657,6 +664,32 @@ public RelNode trimRelNode(RelNode relNode) {
return relNode;
}
+ private Pair<SqlToRelConverter, SqlValidator> createSqlToRelConverter() {
+ final RelDataTypeFactory typeFactory = getTypeFactory();
+ final Prepare.CatalogReader catalogReader =
Review comment:
No, we better put the validator creation and converter creation in 2
methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
