julianhyde commented on a change in pull request #2444:
URL: https://github.com/apache/calcite/pull/2444#discussion_r660192948
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlBasicAggFunction.java
##########
@@ -181,7 +184,21 @@ public SqlBasicAggFunction withAllowsSeparator(boolean
allowsSeparator) {
getReturnTypeInference(), getOperandTypeInference(),
getOperandTypeChecker(), getFunctionType(), requiresOrder(),
requiresOver(), requiresGroupOrder(), distinctOptionality, syntax,
- allowsNullTreatment, allowsSeparator);
+ allowsNullTreatment, allowsSeparator, isPercentile);
+ }
+
+ /** Returns whether this aggregate function is a PERCENTILE function. */
+ public boolean isPercentile() {
Review comment:
Move this method to the base class. (It can have a default 'false' in
the base class.)
Then we can skip the `instanceof` and cast before calling this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
