a-rafay commented on a change in pull request #2444:
URL: https://github.com/apache/calcite/pull/2444#discussion_r660024016
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java
##########
@@ -1181,6 +1185,20 @@ public static Expression multiplyDivide(Expression e,
BigDecimal multiplier,
}
}
+ /** Implementor for the {@code PERCENTILE_CONT} aggregate function. */
+ static class PercentileContImplementor extends StrictAggImplementor {
Review comment:
I thought it was a requirement to add it to the aggMap. So created an
empty implementor. Cleaned up.
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlBasicAggFunction.java
##########
@@ -181,7 +184,21 @@ public SqlBasicAggFunction withAllowsSeparator(boolean
allowsSeparator) {
getReturnTypeInference(), getOperandTypeInference(),
getOperandTypeChecker(), getFunctionType(), requiresOrder(),
requiresOver(), requiresGroupOrder(), distinctOptionality, syntax,
- allowsNullTreatment, allowsSeparator);
+ allowsNullTreatment, allowsSeparator, isPercentile);
+ }
+
+ /** Returns whether this aggregate function is a PERCENTILE function. */
+ public boolean isPercentile() {
Review comment:
This is not in the latest patch anymore. I have moved all the code into
a separate visitor which does not use any downcasting/instance checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
