zacMode commented on a change in pull request #148:
URL: https://github.com/apache/calcite-avatica/pull/148#discussion_r660746418
##########
File path:
core/src/main/java/org/apache/calcite/avatica/BuiltInConnectionProperty.java
##########
@@ -86,7 +86,10 @@
KEY_PASSWORD("key_password", Type.STRING, "", false),
HOSTNAME_VERIFICATION("hostname_verification", Type.ENUM,
HostnameVerification.STRICT,
- HostnameVerification.class, false);
+ HostnameVerification.class, false),
+
+ /** The number of rows to fetch per call, default is 100 rows. */
+ FETCH_ROW_COUNT("fetch_row_count", Type.NUMBER,
AvaticaStatement.DEFAULT_FETCH_SIZE, false);
Review comment:
I would second @julianhyde 's [feedback
here](https://issues.apache.org/jira/browse/CALCITE-2322?focusedCommentId=17370941&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17370941):
> not "default_fetch_row_count" (because it is understood that this is a
default that can be overridden per-statement; furthermore, there is a default
default, which is 100);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
