joshelser commented on a change in pull request #148:
URL: https://github.com/apache/calcite-avatica/pull/148#discussion_r739412781
##########
File path: core/src/main/java/org/apache/calcite/avatica/MetaImpl.java
##########
@@ -1543,13 +1543,21 @@ private FetchIterable(AvaticaStatement stmt, QueryState
state, Frame firstFrame)
private class FetchIterator implements Iterator<Object> {
private final AvaticaStatement stmt;
private final QueryState state;
+ private final int fetchRowCount;
Review comment:
+1 for using the same terminology
##########
File path:
core/src/main/java/org/apache/calcite/avatica/BuiltInConnectionProperty.java
##########
@@ -86,7 +86,10 @@
KEY_PASSWORD("key_password", Type.STRING, "", false),
HOSTNAME_VERIFICATION("hostname_verification", Type.ENUM,
HostnameVerification.STRICT,
- HostnameVerification.class, false);
+ HostnameVerification.class, false),
+
+ /** The number of rows to fetch per call, default is 100 rows. */
+ FETCH_SIZE_ROWS("fetch_size_rows", Type.NUMBER,
AvaticaStatement.DEFAULT_FETCH_SIZE, false);
Review comment:
Playing Devil's Advocate: if Avatica is focused as a JDBC abstraction
layer, should we just call the client configuration property `fetch_size`
instead of `fetch_size_rows`? I think the javadoc here and in ConnectionConfig
appropriately explains what `fetchSize` means.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
