stoty commented on a change in pull request #150:
URL: https://github.com/apache/calcite-avatica/pull/150#discussion_r694994159
##########
File path: core/src/main/java/org/apache/calcite/avatica/ColumnMetaData.java
##########
@@ -360,6 +361,8 @@ public ColumnMetaData setRep(Rep rep) {
builder.put(rep.clazz, rep);
}
builder.put(byte[].class, BYTE_STRING);
+ //The lookup code is not smart enough to handle subclasses
+ builder.put(BigDecimal.class, NUMBER);
Review comment:
Adding `BIG_DECIMAL(BigDecimal.class, Types.NUMERIC),` works.
However, ColumnMetaData.Rep seems to be mapped to
org.apache.calcite.avatica.proto.Common.Rep, so that would
change the wire representation, which may cause compatibility issues.
I admit that I haven't traced through the whole stack, but there are
multiple comments that we want to map everything to NUMBER, so it may not be
desirable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
