joshelser commented on a change in pull request #150:
URL: https://github.com/apache/calcite-avatica/pull/150#discussion_r695016007
##########
File path: core/src/main/java/org/apache/calcite/avatica/ColumnMetaData.java
##########
@@ -360,6 +361,8 @@ public ColumnMetaData setRep(Rep rep) {
builder.put(rep.clazz, rep);
}
builder.put(byte[].class, BYTE_STRING);
+ //The lookup code is not smart enough to handle subclasses
+ builder.put(BigDecimal.class, NUMBER);
Review comment:
Yeah, this is a rats nest that I am mostly responsible for. The
type-wrangling is the worst part about Avatica (especially with trying to
support both json and protobuf). The Javadoc on TypedValue is the best
explanation I can give as to the different "representations" of data on the
wire that Avatica is following.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
