beyond1920 commented on a change in pull request #2524:
URL: https://github.com/apache/calcite/pull/2524#discussion_r716130321
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -2351,7 +2399,16 @@ SqlNode TableFunctionCall(SqlParserPos pos) :
funcType =
SqlFunctionCategory.USER_DEFINED_TABLE_SPECIFIC_FUNCTION;
}
]
- call = NamedRoutineCall(funcType, ExprContext.ACCEPT_CURSOR)
+ (
+ {
+ s = span();
+ }
+ // Currenly, only session window table function requires input to be
set semantics
+ <SESSION>
+ call = SetSemanticsWindowTVF(new
SqlIdentifier(Collections.singletonList("SESSION"), s.pos()), funcType)
+ |
Review comment:
Hi @julianhyde I have same concern with @danny0405 , should we have
separate branch for set semantic window(Currently, only session windowing has
set semantics)?
Because based on SQL standard, only input tables with set semantics may be
partitioned or ordered while input table with row semantics may not be
partitioned or ordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
