beyond1920 commented on pull request #2524:
URL: https://github.com/apache/calcite/pull/2524#issuecomment-927221032


   @danny0405 Thanks for review. There are two points left which need more 
disucssion.
   1. Do we need to support the old synatx( DESCRIPTOR(partition_key)) or drop 
the old syntax directly?
   2. Should we have separate branch in Parser.jj for set semantic 
window(Currently, only session windowing has set semantics)? Because based on 
SQL standard, only input tables with set semantics may be partitioned or 
ordered while input table with row semantics may not be partitioned or ordered.
   
![image](https://user-images.githubusercontent.com/1525333/134791877-7b7f3395-e664-49d4-98fc-3c7f93a9ba52.png)
   What do you think about these points, @julianhyde .
   About point 1, should I send a discussion email in calcite mailist in order 
to listen to more users?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to