jamesstarr commented on a change in pull request #2538:
URL: https://github.com/apache/calcite/pull/2538#discussion_r718897621
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/JaninoRelMetadataProvider.java
##########
@@ -193,41 +124,39 @@ public static JaninoRelMetadataProvider
of(RelMetadataProvider provider) {
}
private static <M extends Metadata> MetadataHandler<M> load3(
- MetadataDef<M> def, Multimap<Method, MetadataHandler<M>> map,
- ImmutableList<Class<? extends RelNode>> relClasses) {
+ MetadataDef<M> def, Multimap<Method, ? extends MetadataHandler<?>> map) {
final StringBuilder buff = new StringBuilder();
final String name =
- "GeneratedMetadataHandler_" + def.metadataClass.getSimpleName();
- final Set<MetadataHandler> providerSet = new HashSet<>();
- final List<Pair<String, MetadataHandler>> providerList = new ArrayList<>();
- //noinspection unchecked
- final ReflectiveRelMetadataProvider.Space space =
- new ReflectiveRelMetadataProvider.Space((Multimap) map);
- for (MetadataHandler provider : space.providerMap.values()) {
+ "GeneratedMetadata_" + simpleNameForHandler(def.handlerClass);
+ final Set<MetadataHandler<?>> providerSet = new HashSet<>();
+
+ final Map<MetadataHandler<?>, String> handlerToName = new
LinkedHashMap<>();
+ for (MetadataHandler<?> provider : map.values()) {
if (providerSet.add(provider)) {
Review comment:
Changed to getMetadataDelegateRel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
