jamesstarr commented on a change in pull request #2538:
URL: https://github.com/apache/calcite/pull/2538#discussion_r718891270
##########
File path:
core/src/main/java/org/apache/calcite/rel/metadata/JaninoRelMetadataProvider.java
##########
@@ -475,33 +356,15 @@ private static StringBuilder paramList(StringBuilder
buff, Method method) {
synchronized <M extends Metadata, H extends MetadataHandler<M>> H revise(
Class<? extends RelNode> rClass, MetadataDef<M> def) {
- if (ALL_RELS.add(rClass)) {
- HANDLERS.invalidateAll();
- }
//noinspection unchecked
return (H) create(def);
}
/** Registers some classes. Does not flush the providers, but next time we
* need to generate a provider, it will handle all of these classes. So,
* calling this method reduces the number of times we need to re-generate. */
+ @Deprecated
public void register(Iterable<Class<? extends RelNode>> classes) {
- // Register the classes and their base classes up to RelNode. Don't bother
Review comment:
There is no loss in functionality. No changes are needed. Hive and
other projects nodes are handle via instanceof for doing the dispatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
